[Asterisk-code-review] force inline: remove all force inline from asterisk. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10936 )

Change subject: force_inline: remove all force_inline from asterisk.
......................................................................


Patch Set 4:

> Would it make sense then to leave the function definitions alone,
 > but move the code into another function, which is then called by
 > the current one? Thus, not modifying the definition, but making
 > them all one-line calls to another function that resides in a *.c
 > file.
 > 
 > The original function would continue to be inlined, but then the
 > compiler could decide on the subfunction?
 > 
 > Would that work to not break abi and still fix the problem while
 > working around the compiler issue?

No.  The contents of an inlined function are public.  Making it a wrapper function that calls another function doesn't fix the initial issue and breaks backwards compatibility.  The internal function does not exist on earlier versions.


-- 
To view, visit https://gerrit.asterisk.org/10936
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a90249763a7139fd12c54ad4e0e8d5cbbed14f9
Gerrit-Change-Number: 10936
Gerrit-PatchSet: 4
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Comment-Date: Mon, 18 Feb 2019 20:03:17 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190218/9571970b/attachment.html>