[Asterisk-code-review] taskprocessor: Enable subsystems and overload by subsystem (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/11001 )

Change subject: taskprocessor:  Enable subsystems and overload by subsystem
......................................................................


Patch Set 2:

This patch ignores the fact that PJSIP can be feeding the other subsystems that get overloaded.  If PJSIP can throttle back the other subsystems will have a chance to recover.

There are two other taskprocessors that are directly connected to the PJSIP subsystem that do not get affected by this patch: The 'SIP' and 'SIP-control' taskprocessors.  These two taskprocessors control the thread pool.  See ast_threadpool_create() when it creates taskprocessors.  Giving the threadpool taskprocessors names that match the scheme devised by this patch could help.  Suggest using <subsystem>/pool and <subsystem>/pool-control format.

The subp:xxx and subm:xxx taskprocessors are part of stasis so they should get new names to reflect what they are.  Suggest stasis/m:xxx and stasis/p:xxx so they are identified as part of stasis.

The original name scheme (sub%c:<subscriber-name>) for the stasis subscriptions was to help with the taskprocessor name length.  The subscriber name can be quite lengthy.

I suppose if we add a taskprocessor alert registration system to let taskprocessors know if anyone cares about the overload status of taskprocessors then the taskprocessor overload messages don't need to be generated.

Maybe we really need to create a heirarchy of who cares about when a taskprocessor gets overloaded when the taskprocessor is created.
Maybe we need to track who creates jobs for a taskprocessor to know who should care if it gets overloaded.


-- 
To view, visit https://gerrit.asterisk.org/11001
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c19068bb2fc26610a9f0b8624bdf577a04fcd56
Gerrit-Change-Number: 11001
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 20:10:40 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190215/da805f60/attachment-0001.html>