<p style="white-space: pre-wrap; word-wrap: break-word;">This patch ignores the fact that PJSIP can be feeding the other subsystems that get overloaded. If PJSIP can throttle back the other subsystems will have a chance to recover.</p><p style="white-space: pre-wrap; word-wrap: break-word;">There are two other taskprocessors that are directly connected to the PJSIP subsystem that do not get affected by this patch: The 'SIP' and 'SIP-control' taskprocessors. These two taskprocessors control the thread pool. See ast_threadpool_create() when it creates taskprocessors. Giving the threadpool taskprocessors names that match the scheme devised by this patch could help. Suggest using <subsystem>/pool and <subsystem>/pool-control format.</p><p style="white-space: pre-wrap; word-wrap: break-word;">The subp:xxx and subm:xxx taskprocessors are part of stasis so they should get new names to reflect what they are. Suggest stasis/m:xxx and stasis/p:xxx so they are identified as part of stasis.</p><p style="white-space: pre-wrap; word-wrap: break-word;">The original name scheme (sub%c:<subscriber-name>) for the stasis subscriptions was to help with the taskprocessor name length. The subscriber name can be quite lengthy.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I suppose if we add a taskprocessor alert registration system to let taskprocessors know if anyone cares about the overload status of taskprocessors then the taskprocessor overload messages don't need to be generated.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Maybe we really need to create a heirarchy of who cares about when a taskprocessor gets overloaded when the taskprocessor is created.<br>Maybe we need to track who creates jobs for a taskprocessor to know who should care if it gets overloaded.</p><p><a href="https://gerrit.asterisk.org/11001">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/11001">change 11001</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/11001"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8c19068bb2fc26610a9f0b8624bdf577a04fcd56 </div>
<div style="display:none"> Gerrit-Change-Number: 11001 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 15 Feb 2019 20:10:40 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-HasLabels: No </div>