[Asterisk-code-review] force inline: remove all force inline from asterisk. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10939 )

Change subject: force_inline: remove all force_inline from asterisk.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

What if we simply remove the `force_inline` but leave the functions in headers?

https://gerrit.asterisk.org/#/c/10939/2/include/asterisk/strings.h
File include/asterisk/strings.h:

https://gerrit.asterisk.org/#/c/10939/2/include/asterisk/strings.h@94
PS2, Line 94: int attribute_pure ast_begins_with(const char *str, const char *prefix);
I think this an ABI breaking change.

If someone compiles a binary module against versions of Asterisk with this patch included, that module would link against an actual symbol "ast_begins_with".  That symbol is not exported by Asterisk in <=13.25.0, so the module would suddenly require Asterisk 13.26.0 (without any changes to the module source).



-- 
To view, visit https://gerrit.asterisk.org/10939
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a90249763a7139fd12c54ad4e0e8d5cbbed14f9
Gerrit-Change-Number: 10939
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 16:38:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190213/e80a3f2c/attachment-0001.html>