<p style="white-space: pre-wrap; word-wrap: break-word;">What if we simply remove the `force_inline` but leave the functions in headers?</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10939">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10939/2/include/asterisk/strings.h">File include/asterisk/strings.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10939/2/include/asterisk/strings.h@94">Patch Set #2, Line 94:</a> <code style="font-family:monospace,monospace">int attribute_pure ast_begins_with(const char *str, const char *prefix);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this an ABI breaking change.</p><p style="white-space: pre-wrap; word-wrap: break-word;">If someone compiles a binary module against versions of Asterisk with this patch included, that module would link against an actual symbol "ast_begins_with".  That symbol is not exported by Asterisk in <=13.25.0, so the module would suddenly require Asterisk 13.26.0 (without any changes to the module source).</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10939">change 10939</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10939"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2a90249763a7139fd12c54ad4e0e8d5cbbed14f9 </div>
<div style="display:none"> Gerrit-Change-Number: 10939 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Chris Savinovich <csavinovich@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 13 Feb 2019 16:38:56 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>