[Asterisk-code-review] res/res rtp asterisk: clear smoother when updating txformat ... (asterisk[13])

[Joshua C. Colp]

Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/10989 )

Change subject: res/res_rtp_asterisk: clear smoother when updating txformat in p2p_write
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10989/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/10989/1/res/res_rtp_asterisk.c@5231
PS1, Line 5231: 		if (rtp->smoother) {
              : 			ast_smoother_free(rtp->smoother);
              : 			rtp->smoother = NULL;
              : 		}
This will be executed every packet, instead of only when the format changes. This would result in a smoother not really being used.



-- 
To view, visit https://gerrit.asterisk.org/10989
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e67f144963787fff9b4d79ac500514fb40cdc6
Gerrit-Change-Number: 10989
Gerrit-PatchSet: 1
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 12:13:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190213/c4a076bc/attachment.html>