[Asterisk-code-review] res/res rtp asterisk: clear smoother when updating txformat ... (asterisk[13])

[Torrey Searle]

Torrey Searle has uploaded this change for review. ( https://gerrit.asterisk.org/10989


Change subject: res/res_rtp_asterisk: clear smoother when updating txformat in p2p_write
......................................................................

res/res_rtp_asterisk: clear smoother when updating txformat in p2p_write

p2p_write updates txformat, if the smoother is not destroied the format
expected by the smoother can fall out of sync with the currently used
format in the bridge.  This can lead to one way audio issues.

ASTERISK-28284 #close

Change-Id: I84e67f144963787fff9b4d79ac500514fb40cdc6
---
M res/res_rtp_asterisk.c
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/89/10989/1

diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c
index 77eba21..0226076 100644
--- a/res/res_rtp_asterisk.c
+++ b/res/res_rtp_asterisk.c
@@ -5227,6 +5227,11 @@
 		}
 
 		ao2_replace(bridged->lasttxformat, payload_type->format);
+		/* always remove the smoother when updating lasttxformat */
+		if (rtp->smoother) {
+			ast_smoother_free(rtp->smoother);
+			rtp->smoother = NULL;
+		}
 	}
 
 	ast_rtp_instance_get_remote_address(instance1, &remote_address);

-- 
To view, visit https://gerrit.asterisk.org/10989
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84e67f144963787fff9b4d79ac500514fb40cdc6
Gerrit-Change-Number: 10989
Gerrit-PatchSet: 1
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190212/2ac4a53a/attachment.html>