[Asterisk-code-review] res pjsip registrar: lock transport monitor when setting 're... (asterisk[13])

Kevin Harwell asteriskteam at digium.com
Thu Feb 7 14:28:20 CST 2019


Hello Richard Mudgett, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/10968

to look at the new patch set (#3).

Change subject: res_pjsip_registrar: lock transport monitor when setting 'removing' flag
......................................................................

res_pjsip_registrar: lock transport monitor when setting 'removing' flag

A previous patch attempt to mitigate blocked threads on transport shutdown for
a given contact. It was thought that a second lock could be avoided by checking
the 'removing' flag on the transport monitor twice (once before and once after
the normal named aor locking). However as with usual threading issues if the
timing was right the original problem still occured.

This patch adds locking around the first 'removing' flag check and set, thus
nullifying the secondary check, so it was removed.

ASTERISK-28213

Change-Id: Iaa8e36e5311789549b76d8de42dfcea96013b2ed
---
M res/res_pjsip_registrar.c
1 file changed, 12 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/68/10968/3
-- 
To view, visit https://gerrit.asterisk.org/10968
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa8e36e5311789549b76d8de42dfcea96013b2ed
Gerrit-Change-Number: 10968
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190207/942de763/attachment.html>


More information about the asterisk-code-review mailing list