[Asterisk-code-review] res pjsip registrar: lock transport monitor when setting 're... (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Thu Feb 7 13:03:11 CST 2019


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10968 )

Change subject: res_pjsip_registrar: lock transport monitor when setting 'removing' flag
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10968/2/res/res_pjsip_registrar.c
File res/res_pjsip_registrar.c:

https://gerrit.asterisk.org/#/c/10968/2/res/res_pjsip_registrar.c@344
PS2, Line 344: 		ao2_ref(monitor, -1);
             : 		monitor->removing = 0;
* Need to swap these two lines.  This might be the last monitor ref.

* We should have monitor locked while modifying removing.



-- 
To view, visit https://gerrit.asterisk.org/10968
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa8e36e5311789549b76d8de42dfcea96013b2ed
Gerrit-Change-Number: 10968
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 07 Feb 2019 19:03:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190207/96bcf34f/attachment.html>


More information about the asterisk-code-review mailing list