[Asterisk-code-review] netsock2: Implementation for ast_sockaddr_from_sockaddr. (asterisk[13])

[Jaco Kroon]

Jaco Kroon has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13361 )

Change subject: netsock2: Implementation for ast_sockaddr_from_sockaddr.
......................................................................


Patch Set 4:

> Patch Set 4: Code-Review-1
> 
> (1 comment)
> 
> Since there's already an "ast_sockaddr_copy_sockaddr" can ast_sockaddr_from_sockaddr just be a #DEFINE that wraps the existing function?

Since that function doesn't exist in 13:

jkroon at plastiekpoot ~/projects/asterisk ((HEAD detached at origin/13)) $ grep -r ast_sockaddr_copy_sockaddr .
[1] jkroon at plastiekpoot ~/projects/asterisk ((HEAD detached at origin/13)) $          

jkroon at plastiekpoot ~/projects/asterisk (master) $ grep -r ast_sockaddr_copy_sockaddr .
./include/asterisk/netsock2.h:static inline void ast_sockaddr_copy_sockaddr(struct ast_sockaddr *dst,
./main/io.c:    ast_sockaddr_copy_sockaddr(&fd_addr, &ss, ss_len);
jkroon at plastiekpoot ~/projects/asterisk (master) $ 

Perhaps I should rather just back-port that existing function?

I mean really, s/copy/from/ ... for all practical purposes.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13361
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Iee604e96e9096c79b477d6e5ff310cf0b06dae86
Gerrit-Change-Number: 13361
Gerrit-PatchSet: 4
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 19 Dec 2019 09:38:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191219/7b75f077/attachment.html>