[Asterisk-code-review] netsock2: Implementation for ast_sockaddr_from_sockaddr. (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13361 )

Change subject: netsock2: Implementation for ast_sockaddr_from_sockaddr.
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

Since there's already an "ast_sockaddr_copy_sockaddr" can ast_sockaddr_from_sockaddr just be a #DEFINE that wraps the existing function?

https://gerrit.asterisk.org/c/asterisk/+/13361/4/include/asterisk/netsock2.h 
File include/asterisk/netsock2.h:

https://gerrit.asterisk.org/c/asterisk/+/13361/4/include/asterisk/netsock2.h@732 
PS4, Line 732:  *
Can you add "\since" parameters here?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13361
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Iee604e96e9096c79b477d6e5ff310cf0b06dae86
Gerrit-Change-Number: 13361
Gerrit-PatchSet: 4
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 16 Dec 2019 16:17:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191216/af858b50/attachment.html>