[Asterisk-code-review] confbridge: Add support for specifying maximum sample rate. (asterisk[13])

[Joshua C. Colp]

Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13441 )

Change subject: confbridge: Add support for specifying maximum sample rate.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13441/1/bridges/bridge_softmix.c 
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/c/asterisk/+/13441/1/bridges/bridge_softmix.c@943 
PS1, Line 943:  != 
> Not sure what the actual conditions would be but should this be a ">" rather than a "!="?
Nope, when configured the internal sample rate should never be above the maximum rate. We just want to raise it to the highest possible when someone has a sample rate above the maximum.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13441
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Idff80896ccfb8a58a816e4ce9ac4ebde785963ee
Gerrit-Change-Number: 13441
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 15:22:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191213/52095ef0/attachment.html>