[Asterisk-code-review] confbridge: Add support for specifying maximum sample rate. (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13441 )

Change subject: confbridge: Add support for specifying maximum sample rate.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/13441/1/bridges/bridge_softmix.c 
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/c/asterisk/+/13441/1/bridges/bridge_softmix.c@943 
PS1, Line 943:  != 
Not sure what the actual conditions would be but should this be a ">" rather than a "!="?


https://gerrit.asterisk.org/c/asterisk/+/13441/1/include/asterisk/bridge.h 
File include/asterisk/bridge.h:

https://gerrit.asterisk.org/c/asterisk/+/13441/1/include/asterisk/bridge.h@258 
PS1, Line 258: 	/*!
             : 	 * \brief The maximum sample rate softmix uses to mix channels.
             : 	 *
             : 	 * \note If this value is 0, there is no maximum sample rate.
             : 	 */
             : 	unsigned int maximum_sample_rate;
             : 	/*!
Since this is a public structure, this should probably go at the end.


https://gerrit.asterisk.org/c/asterisk/+/13441/1/include/asterisk/bridge.h@871 
PS1, Line 871:  *
Add a \since?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13441
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Idff80896ccfb8a58a816e4ce9ac4ebde785963ee
Gerrit-Change-Number: 13441
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 15:15:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191213/2f4dc912/attachment.html>