[Asterisk-code-review] app_chanisavail/cdr: ChanIsAvail sometimes fails to deactivate CDR. (asterisk[16])

[Frederic LE FOLL]

Frederic LE FOLL has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13310 )

Change subject: app_chanisavail/cdr: ChanIsAvail sometimes fails to deactivate CDR.
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/13310/2/apps/app_chanisavail.c 
File apps/app_chanisavail.c:

https://gerrit.asterisk.org/c/asterisk/+/13310/2/apps/app_chanisavail.c@31 
PS2, Line 31: <depend>func_cdr</depend>
> It should be declared as an optional dependency at the bottom of the source (replace the AST_MODULE_ […]
"depend" removed.

AST_MODULE_INFO with .optional_modules added.
Other modules are unanimous: they place .support_level ahead (even if it is at the very bottom of ast_module_info in module.h).So,I moved it ahead too...

About Asterisk 13: if the question of Cherry Pick arises, I think that former AST_MODULE_INFO_STANDARD_EXTENDED declaration still is applicable: the only effect a CDR_PROP "disappearing" during ChansIsAvail execution will be a series of WARNING logs for last peers to evaluate.


https://gerrit.asterisk.org/c/asterisk/+/13310/2/apps/app_chanisavail.c@183 
PS2, Line 183: 				if (ast_custom_function_find("CDR_PROP") != NULL)
             : 						ast_func_write(tempchan, "CDR_PROP(disable)", "1");
> Guidelines: Always use curly braces. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13310
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I1cbe09e8d2169c0962c1195133ff260d291f2074
Gerrit-Change-Number: 13310
Gerrit-PatchSet: 5
Gerrit-Owner: Frederic LE FOLL <frederic.lefoll at c-s.fr>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Thu, 12 Dec 2019 18:44:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Corey Farrell <git at cfware.com>
Comment-In-Reply-To: Frederic LE FOLL <frederic.lefoll at c-s.fr>
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191212/33c016ac/attachment-0001.html>