<p><a href="https://gerrit.asterisk.org/c/asterisk/+/13310">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13310/2/apps/app_chanisavail.c">File apps/app_chanisavail.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13310/2/apps/app_chanisavail.c@31">Patch Set #2, Line 31:</a> <code style="font-family:monospace,monospace"><depend>func_cdr</depend></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">It should be declared as an optional dependency at the bottom of the source (replace the AST_MODULE_ […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">"depend" removed.</p><p style="white-space: pre-wrap; word-wrap: break-word;">AST_MODULE_INFO with .optional_modules added.<br>Other modules are unanimous: they place .support_level ahead (even if it is at the very bottom of ast_module_info in module.h).So,I moved it ahead too...</p><p style="white-space: pre-wrap; word-wrap: break-word;">About Asterisk 13: if the question of Cherry Pick arises, I think that former AST_MODULE_INFO_STANDARD_EXTENDED declaration still is applicable: the only effect a CDR_PROP "disappearing" during ChansIsAvail execution will be a series of WARNING logs for last peers to evaluate.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13310/2/apps/app_chanisavail.c@183">Patch Set #2, Line 183:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                              if (ast_custom_function_find("CDR_PROP") != NULL)<br>                                           ast_func_write(tempchan, "CDR_PROP(disable)", "1");<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Guidelines: Always use curly braces. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13310">change 13310</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13310"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I1cbe09e8d2169c0962c1195133ff260d291f2074 </div>
<div style="display:none"> Gerrit-Change-Number: 13310 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Frederic LE FOLL <frederic.lefoll@c-s.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-CC: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 12 Dec 2019 18:44:27 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Comment-In-Reply-To: Frederic LE FOLL <frederic.lefoll@c-s.fr> </div>
<div style="display:none"> Comment-In-Reply-To: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>