[Asterisk-code-review] app_queue: Fix old confusing comment about when the members are called (asterisk[16])

[Joshua Colp]

Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/13354 )

Change subject: app_queue: Fix old confusing comment about when the members are called
......................................................................

app_queue: Fix old confusing comment about when the members are called

ASTERISK-28644

Change-Id: I2771a931d00a8fc2b9f9a4d1a33ea8f1ad24e06b
---
M apps/app_queue.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  George Joseph: Looks good to me, approved



diff --git a/apps/app_queue.c b/apps/app_queue.c
index 4ba8e6a..fed986f 100644
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -4904,7 +4904,7 @@
 				ast_verb(3, "Auto-Pausing Queue Member %s in all queues since they failed to answer on queue %s.\n",
 						interface, qe->parent->name);
 			} else {
-					ast_verb(3, "Failed to pause Queue Member %s in all queues!\n", interface);
+				ast_verb(3, "Failed to pause Queue Member %s in all queues!\n", interface);
 			}
 		}
 	}
@@ -6850,8 +6850,7 @@
 		tmp->lastcall = cur->lastcall;
 		tmp->lastqueue = cur->lastqueue;
 		ast_copy_string(tmp->interface, cur->interface, sizeof(tmp->interface));
-		/* Special case: If we ring everyone, go ahead and ring them, otherwise
-		   just calculate their metric for the appropriate strategy */
+		/* Calculate the metric for the appropriate strategy. */
 		if (!calc_metric(qe->parent, cur, x++, qe, tmp)) {
 			/* Put them in the list of outgoing thingies...  We're ready now.
 			   XXX If we're forcibly removed, these outgoing calls won't get
@@ -6887,6 +6886,7 @@
 	orig = to;
 	++qe->pending;
 	ao2_unlock(qe->parent);
+	/* Call the queue members with the best metric now. */
 	ring_one(qe, outgoing, &numbusies);
 	lpeer = wait_for_answer(qe, outgoing, &to, &digit, numbusies,
 		ast_test_flag(&(bridge_config.features_caller), AST_FEATURE_DISCONNECT),

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13354
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I2771a931d00a8fc2b9f9a4d1a33ea8f1ad24e06b
Gerrit-Change-Number: 13354
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191209/ac8b1468/attachment.html>