<p>Joshua Colp <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13354">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  George Joseph: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">app_queue: Fix old confusing comment about when the members are called<br><br>ASTERISK-28644<br><br>Change-Id: I2771a931d00a8fc2b9f9a4d1a33ea8f1ad24e06b<br>---<br>M apps/app_queue.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/apps/app_queue.c b/apps/app_queue.c</span><br><span>index 4ba8e6a..fed986f 100644</span><br><span>--- a/apps/app_queue.c</span><br><span>+++ b/apps/app_queue.c</span><br><span>@@ -4904,7 +4904,7 @@</span><br><span>                             ast_verb(3, "Auto-Pausing Queue Member %s in all queues since they failed to answer on queue %s.\n",</span><br><span>                                               interface, qe->parent->name);</span><br><span>                  } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                                        ast_verb(3, "Failed to pause Queue Member %s in all queues!\n", interface);</span><br><span style="color: hsl(120, 100%, 40%);">+                         ast_verb(3, "Failed to pause Queue Member %s in all queues!\n", interface);</span><br><span>                        }</span><br><span>            }</span><br><span>    }</span><br><span>@@ -6850,8 +6850,7 @@</span><br><span>            tmp->lastcall = cur->lastcall;</span><br><span>                 tmp->lastqueue = cur->lastqueue;</span><br><span>               ast_copy_string(tmp->interface, cur->interface, sizeof(tmp->interface));</span><br><span style="color: hsl(0, 100%, 40%);">-               /* Special case: If we ring everyone, go ahead and ring them, otherwise</span><br><span style="color: hsl(0, 100%, 40%);">-            just calculate their metric for the appropriate strategy */</span><br><span style="color: hsl(120, 100%, 40%);">+                /* Calculate the metric for the appropriate strategy. */</span><br><span>             if (!calc_metric(qe->parent, cur, x++, qe, tmp)) {</span><br><span>                        /* Put them in the list of outgoing thingies...  We're ready now.</span><br><span>                           XXX If we're forcibly removed, these outgoing calls won't get</span><br><span>@@ -6887,6 +6886,7 @@</span><br><span>     orig = to;</span><br><span>   ++qe->pending;</span><br><span>    ao2_unlock(qe->parent);</span><br><span style="color: hsl(120, 100%, 40%);">+    /* Call the queue members with the best metric now. */</span><br><span>       ring_one(qe, outgoing, &numbusies);</span><br><span>      lpeer = wait_for_answer(qe, outgoing, &to, &digit, numbusies,</span><br><span>                ast_test_flag(&(bridge_config.features_caller), AST_FEATURE_DISCONNECT),</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13354">change 13354</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13354"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I2771a931d00a8fc2b9f9a4d1a33ea8f1ad24e06b </div>
<div style="display:none"> Gerrit-Change-Number: 13354 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Walter Doekes <walter+asterisk@wjd.nu> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>