[Asterisk-code-review] res_pjsip_registrar.c: Prevent possible buffer overflow with domain a... (asterisk[13])

Sean Bright asteriskteam at digium.com
Wed Dec 4 16:14:37 CST 2019


Hello Friendly Automation, Benjamin Keith Ford, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/13368

to look at the new patch set (#2).

Change subject: res_pjsip_registrar.c: Prevent possible buffer overflow with domain aliases
......................................................................

res_pjsip_registrar.c: Prevent possible buffer overflow with domain aliases

We're appropriately sizing the id_domain_alias buffer, but then copying the data
into the id_domain one. We were then using the uninitialized id_domain_alias
buffer we just allocated.

This is ASTERISK~28641 adjacent, but significant enough to warrant its own
patch.

Change-Id: I81c38724d18deab8c6573153e2b99dbb6e2f33d9
---
M res/res_pjsip_registrar.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/68/13368/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13368
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I81c38724d18deab8c6573153e2b99dbb6e2f33d9
Gerrit-Change-Number: 13368
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191204/3f8c8c57/attachment.html>


More information about the asterisk-code-review mailing list