[Asterisk-code-review] res_pjsip_registrar.c: Prevent possible buffer overflow with domain a... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13368 )

Change subject: res_pjsip_registrar.c: Prevent possible buffer overflow with domain aliases
......................................................................


Patch Set 1:

(1 comment)

Something to consider about what was happening.  domain_alias was not even compared.

https://gerrit.asterisk.org/c/asterisk/+/13368/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/13368/1//COMMIT_MSG@10 
PS1, Line 10: into the id_domain one. This is ASTERISK~28641 adjacent, but significant enough
id_domain one and then we weren't even using the buffer we just setup.  We were using the uninitialized buffer we just allocated.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13368
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I81c38724d18deab8c6573153e2b99dbb6e2f33d9
Gerrit-Change-Number: 13368
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 04 Dec 2019 21:49:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191204/117c5bd2/attachment-0001.html>