[Asterisk-code-review] app_dial.c: RINGTIME, PROGRESSTIME and ms resolution dial timings (...asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11207 )

Change subject: app_dial.c: RINGTIME, PROGRESSTIME and ms resolution dial timings
......................................................................


Patch Set 6: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/11207/6/include/asterisk/channel.h 
File include/asterisk/channel.h:

https://gerrit.asterisk.org/#/c/11207/6/include/asterisk/channel.h@2342 
PS6, Line 2342:  * \since 13
I'm not sure how helpful these are, but I've see them added now to new functions. If they are going to be added they should reflect the next release version(s) these changes will go into:

\since 13.27.0
\since 16.4.0


https://gerrit.asterisk.org/#/c/11207/6/include/asterisk/channel.h@2343 
PS6, Line 2343:  * \brief Obtain how long the channel since the channel was created in ms
Change this to something like:

"Obtain how long it's been, in milliseconds, since the channel was created"


https://gerrit.asterisk.org/#/c/11207/6/include/asterisk/channel.h@2348 
PS6, Line 2348:  * \retval The number of milliseconds the channel has been up
s/the channel has been up/since channel creation


https://gerrit.asterisk.org/#/c/11207/6/include/asterisk/channel.h@2364 
PS6, Line 2364:  * \since 13
Same for this one. This needs to be:

\since 13.27.0
\since 16.4.0



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11207
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: If95f1a7d8c4acbac740037de0c6e3109ff6620b1
Gerrit-Change-Number: 11207
Gerrit-PatchSet: 6
Gerrit-Owner: Antoni Goldstein <action at gdevel.com>
Gerrit-Reviewer: Antoni Goldstein <action at gdevel.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 18:35:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190423/cc554a73/attachment-0001.html>