<p>Patch set 6:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11207">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11207/6/include/asterisk/channel.h">File include/asterisk/channel.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11207/6/include/asterisk/channel.h@2342">Patch Set #6, Line 2342:</a> <code style="font-family:monospace,monospace"> * \since 13</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not sure how helpful these are, but I've see them added now to new functions. If they are going to be added they should reflect the next release version(s) these changes will go into:</p><p style="white-space: pre-wrap; word-wrap: break-word;">\since 13.27.0<br>\since 16.4.0</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11207/6/include/asterisk/channel.h@2343">Patch Set #6, Line 2343:</a> <code style="font-family:monospace,monospace"> * \brief Obtain how long the channel since the channel was created in ms</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Change this to something like:</p><p style="white-space: pre-wrap; word-wrap: break-word;">"Obtain how long it's been, in milliseconds, since the channel was created"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11207/6/include/asterisk/channel.h@2348">Patch Set #6, Line 2348:</a> <code style="font-family:monospace,monospace"> * \retval The number of milliseconds the channel has been up</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/the channel has been up/since channel creation</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11207/6/include/asterisk/channel.h@2364">Patch Set #6, Line 2364:</a> <code style="font-family:monospace,monospace"> * \since 13</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same for this one. This needs to be:</p><p style="white-space: pre-wrap; word-wrap: break-word;">\since 13.27.0<br>\since 16.4.0</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11207">change 11207</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11207"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: If95f1a7d8c4acbac740037de0c6e3109ff6620b1 </div>
<div style="display:none"> Gerrit-Change-Number: 11207 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Antoni Goldstein <action@gdevel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Antoni Goldstein <action@gdevel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 23 Apr 2019 18:35:13 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>