[Asterisk-code-review] res_pjsip: Added a norefersub configuration setting (...asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11245 )

Change subject: res_pjsip:  Added a norefersub configuration setting
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

* The alembic script adding the new config option to the ps_globals table is missing.
You can use 2bb1a85135ad_pjsip_add_use_callerid_contact.py as an example.

* A note in the CHANGES file is needed to announce the new global chan_pjsip option.

https://gerrit.asterisk.org/#/c/11245/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/#/c/11245/1//COMMIT_MSG@21 
PS1, Line 21: ASTERISK-12345 #close
Please put the correct issue id here.


https://gerrit.asterisk.org/#/c/11245/1/configs/samples/pjsip.conf.sample 
File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/#/c/11245/1/configs/samples/pjsip.conf.sample@1177 
PS1, Line 1177: 							    
What was once red blobs now seems to be pink.


https://gerrit.asterisk.org/#/c/11245/1/include/asterisk/res_pjsip.h 
File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/#/c/11245/1/include/asterisk/res_pjsip.h@2793 
PS1, Line 2793:  * \since 16.4.0
Unless this is going in other branches \since should not be here.


https://gerrit.asterisk.org/#/c/11245/1/res/res_pjsip/config_global.c 
File res/res_pjsip/config_global.c:

https://gerrit.asterisk.org/#/c/11245/1/res/res_pjsip/config_global.c@725 
PS1, Line 725:         ast_sorcery_object_field_register(sorcery, "global", "norefersub",
Line should be using tabs to indent.


https://gerrit.asterisk.org/#/c/11245/1/res/res_pjsip/config_global.c@727 
PS1, Line 727: OPT_BOOL_T
Use OPT_YESNO_T instead of OPT_BOOL_T.  OPT_BOOL_T uses "true"/"false" for the strings instead of "yes"/"no".



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11245
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0b1c28ebc905d881f4a16e752715487a688b30e9
Gerrit-Change-Number: 11245
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Cropp <dan at amtelco.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 09 Apr 2019 15:43:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190409/ace3cf98/attachment-0001.html>