<ul><li>The alembic script adding the new config option to the ps_globals table is missing.</li><li>You can use 2bb1a85135ad_pjsip_add_use_callerid_contact.py as an example.</li></ul><ul><li>A note in the CHANGES file is needed to announce the new global chan_pjsip option.</li></ul><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11245">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11245/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11245/1//COMMIT_MSG@21">Patch Set #1, Line 21:</a> <code style="font-family:monospace,monospace">ASTERISK-12345 #close</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please put the correct issue id here.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11245/1/configs/samples/pjsip.conf.sample">File configs/samples/pjsip.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11245/1/configs/samples/pjsip.conf.sample@1177">Patch Set #1, Line 1177:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What was once red blobs now seems to be pink.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11245/1/include/asterisk/res_pjsip.h">File include/asterisk/res_pjsip.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11245/1/include/asterisk/res_pjsip.h@2793">Patch Set #1, Line 2793:</a> <code style="font-family:monospace,monospace"> * \since 16.4.0</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Unless this is going in other branches \since should not be here.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11245/1/res/res_pjsip/config_global.c">File res/res_pjsip/config_global.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11245/1/res/res_pjsip/config_global.c@725">Patch Set #1, Line 725:</a> <code style="font-family:monospace,monospace"> ast_sorcery_object_field_register(sorcery, "global", "norefersub",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Line should be using tabs to indent.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11245/1/res/res_pjsip/config_global.c@727">Patch Set #1, Line 727:</a> <code style="font-family:monospace,monospace">OPT_BOOL_T</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use OPT_YESNO_T instead of OPT_BOOL_T. OPT_BOOL_T uses "true"/"false" for the strings instead of "yes"/"no".</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11245">change 11245</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11245"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0b1c28ebc905d881f4a16e752715487a688b30e9 </div>
<div style="display:none"> Gerrit-Change-Number: 11245 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Dan Cropp <dan@amtelco.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 09 Apr 2019 15:43:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>