[Asterisk-code-review] config.c: parsing_extconfig.conf (...asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11232 )

Change subject: config.c: parsing_extconfig.conf
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/11232/3//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/#/c/11232/3//COMMIT_MSG@11 
PS3, Line 11: An "if" was introduced, and if search returns null
            : a warning is printed and line is skipped.
You can remove this last sentence. The commit message should indicate what you fixed, not detail specific code constructs.


https://gerrit.asterisk.org/#/c/11232/3/main/config.c 
File main/config.c:

https://gerrit.asterisk.org/#/c/11232/3/main/config.c@2916 
PS3, Line 2916: 		if (!stringp) {
Assuming the goal is: "Fail if the string does NOT contain a comma" then this should be:

 if (!driver) {


https://gerrit.asterisk.org/#/c/11232/3/main/config.c@2917 
PS3, Line 2917: 			ast_log(LOG_WARNING,"extconfig.conf: value '%s' ignored due to wrong format\n", v->value);
Space after the comma after `LOG_WARNING`



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11232
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Id76b452d8f330d11c2742c37232761ad71472a8b
Gerrit-Change-Number: 11232
Gerrit-PatchSet: 3
Gerrit-Owner: Christian Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 05 Apr 2019 19:19:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190405/0399bf08/attachment.html>