[Asterisk-code-review] config.c: parsing_extconfig.conf (...asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11232 )

Change subject: config.c: parsing_extconfig.conf
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/11232/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/#/c/11232/1//COMMIT_MSG@11 
PS1, Line 11: An "if" was introduced, and if null or blank a
            : warning is printed and line is skipped.
You can remove this last sentence.


https://gerrit.asterisk.org/#/c/11232/1/main/config.c 
File main/config.c:

https://gerrit.asterisk.org/#/c/11232/1/main/config.c@2914 
PS1, Line 2914: 		if (!strstr(buf,",") || !strlen(buf)) {
Add a space between the `strstr` arguments


https://gerrit.asterisk.org/#/c/11232/1/main/config.c@2915 
PS1, Line 2915: 			ast_log(LOG_WARNING,"extconfig.conf: value '%s' ignored due to wrong format\n", v->value);
Add a space after the `LOG_WARNING` argument


https://gerrit.asterisk.org/#/c/11232/1/main/config.c@2919 
PS1, Line 2919: 		driver = strsep(&stringp, ",");
Couldn't we just check that `driver` is non-NULL instead of using the logic above?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11232
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Id76b452d8f330d11c2742c37232761ad71472a8b
Gerrit-Change-Number: 11232
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 05 Apr 2019 12:08:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190405/06986027/attachment.html>