[Asterisk-code-review] res pjsip: improve realtime performance on CLI 'pjsip show c... (asterisk[13])

Kevin Harwell asteriskteam at digium.com
Fri Sep 28 10:44:37 CDT 2018


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/10270 )

Change subject: res_pjsip: improve realtime performance on CLI 'pjsip show contacts'
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10270/1/res/res_pjsip/location.c
File res/res_pjsip/location.c:

https://gerrit.asterisk.org/#/c/10270/1/res/res_pjsip/location.c@a1021
PS1, Line 1021: 
> It's used to gather static contacts... see line 1071.
hrm, I am not seeing it. All I see at 1071 is:

  int flexwidth;

Also when I grep each branches source for 'cli_aor_gather_contacts' I only see the function [definition] and the single call to it that you've removed. Maybe I am missing something else?



-- 
To view, visit https://gerrit.asterisk.org/10270
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0ad65d14952a02fb213273a90f3f680a8149618
Gerrit-Change-Number: 10270
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 15:44:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180928/dce68c17/attachment.html>


More information about the asterisk-code-review mailing list