[Asterisk-code-review] res pjsip: improve realtime performance on CLI 'pjsip show c... (asterisk[13])

Alexei Gradinari asteriskteam at digium.com
Thu Sep 27 12:30:44 CDT 2018


Hello Kevin Harwell, Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/10270

to look at the new patch set (#2).

Change subject: res_pjsip: improve realtime performance on CLI 'pjsip show contacts'
......................................................................

res_pjsip: improve realtime performance on CLI 'pjsip show contacts'

CLI command 'pjsip show contacts' inefficiently make a lot of DB requests.

For example if there are 10k aors then asterisk requests these 10k records
of aor and then does 10k requests of contact - one request per aor.

Even if use 'like <pattern>' the asterisk requests all aor's and contact's
records and then filters them by itself.

This patch gathers contact's container by
- retrieving all dynamic contacts by regex (filtered by reg_server)
- retrieving all aors with permanent contacts
- finally filters container by regex

ASTERISK-28077 #close

Change-Id: Id0ad65d14952a02fb213273a90f3f680a8149618
---
M res/res_pjsip/location.c
1 file changed, 58 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/70/10270/2
-- 
To view, visit https://gerrit.asterisk.org/10270
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id0ad65d14952a02fb213273a90f3f680a8149618
Gerrit-Change-Number: 10270
Gerrit-PatchSet: 2
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180927/3ecf2027/attachment.html>


More information about the asterisk-code-review mailing list