[Asterisk-code-review] rtp engine: rtcp report to json can overflow the ssrc intege... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10149 )

Change subject: rtp_engine: rtcp_report_to_json can overflow the ssrc integer value
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/10149/3/main/json.c
File main/json.c:

https://gerrit.asterisk.org/#/c/10149/3/main/json.c@59
PS3, Line 59: 	int json_int_check[1 / (sizeof(ast_json_int_t) == sizeof(json_int_t))];
> Yeah it would give a divide by zero error. […]
If you plan to check for the define from jansson.h you will need to modify third-party/jansson/Makefile 'configure' target:
configure: source/config.status dest/include/jansson.h

If going in that direction please be sure to test with your system jansson-devel package uninstalled and a clean working copy of Asterisk to verify that configure can find the bundled header.



-- 
To view, visit https://gerrit.asterisk.org/10149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I2af275286ee5e795b79f0c3d450d9e4b28e958b0
Gerrit-Change-Number: 10149
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 21 Sep 2018 15:59:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180921/762c287f/attachment.html>