[Asterisk-code-review] rtp engine: rtcp report to json can overflow the ssrc intege... (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/10149 )

Change subject: rtp_engine: rtcp_report_to_json can overflow the ssrc integer value
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.asterisk.org/#/c/10149/3/include/asterisk/json.h
File include/asterisk/json.h:

https://gerrit.asterisk.org/#/c/10149/3/include/asterisk/json.h@116
PS3, Line 116: #if (HAVE_LLONG_MAX == 1 && HAVE_STRTOLL == 1)
> Richard's comment about this on the master review is correct, we need to check if these are defined. […]
Huh yeah it does fail interesting. Makes more sense that it would. Seems to break the standard though unless I read it wrong.


https://gerrit.asterisk.org/#/c/10149/3/main/json.c
File main/json.c:

https://gerrit.asterisk.org/#/c/10149/3/main/json.c@59
PS3, Line 59: 	int json_int_check[1 / (sizeof(ast_json_int_t) == sizeof(json_int_t))];
> If the sizes do not equal then for example (8 == 4) evaluates to 0, this would cause a divide by zer […]
Yeah it would give a divide by zero error. Kinda cryptic, so going to dump this and try to put something in the configure script. Barring that (or folks find that solution problematic) I'll just go the route of no check.



-- 
To view, visit https://gerrit.asterisk.org/10149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I2af275286ee5e795b79f0c3d450d9e4b28e958b0
Gerrit-Change-Number: 10149
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 21 Sep 2018 15:49:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180921/a6697af7/attachment.html>