[Asterisk-code-review] stasis message.c: Don't create immutable stasis objects with... (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Tue Sep 18 13:06:56 CDT 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10185 )

Change subject: stasis_message.c: Don't create immutable stasis objects with locks.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10185/1//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10185/1//COMMIT_MSG@11
PS1, Line 11: * Creating the stasis message type could crash if the passed in type name
> Maybe I'm misunderstanding, but I thought: […]
Most of the platforms will output "(null)".  However, I know Solaris will crash.

I'll need to fix v15+ to not change the tag passed in as the crash won't happen there.



-- 
To view, visit https://gerrit.asterisk.org/10185
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I28763c58bb9f0b427c11971d0103bf94055e7b32
Gerrit-Change-Number: 10185
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 18 Sep 2018 18:06:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180918/816dcee9/attachment.html>


More information about the asterisk-code-review mailing list