[Asterisk-code-review] stasis message.c: Don't create immutable stasis objects with... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10185 )

Change subject: stasis_message.c: Don't create immutable stasis objects with locks.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10185/1//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10185/1//COMMIT_MSG@11
PS1, Line 11: * Creating the stasis message type could crash if the passed in type name
Maybe I'm misunderstanding, but I thought:
fprintf(file_handle, "%s", NULL) would just output "(null)" or something like that?

FYI the behavior in 15+ is different, NULL tag would cause the REF_DEBUG allocation line to be suppressed.

Not questioning your decision to replace NULL with "" in the code, just commenting on your commit message.



-- 
To view, visit https://gerrit.asterisk.org/10185
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I28763c58bb9f0b427c11971d0103bf94055e7b32
Gerrit-Change-Number: 10185
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 18 Sep 2018 17:50:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180918/14894d88/attachment.html>