[Asterisk-code-review] rtp engine: rtcp report to json can overflow the ssrc intege... (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10150 )

Change subject: rtp_engine: rtcp_report_to_json can overflow the ssrc integer value
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/10150/4/include/asterisk/json.h
File include/asterisk/json.h:

https://gerrit.asterisk.org/#/c/10150/4/include/asterisk/json.h@116
PS4, Line 116: #if (HAVE_LLONG_MAX == 1 && HAVE_STRTOLL == 1)
> According to the C99 standard if those values are not defined they will be replaced with 0. […]
The case of having it defined to zero is not a valid situation for autoconfig.h/autoconfig.h.in conditional values.  The associated comment says you define it to 1 if you have it or don't define it because autoconfig.h.in explicitly undefs it.  It will break things for many of the other HAVE_xxx defines if you do define them to zero because that code uses #ifdef/#ifndef which doesn't care about the value.



-- 
To view, visit https://gerrit.asterisk.org/10150
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I2af275286ee5e795b79f0c3d450d9e4b28e958b0
Gerrit-Change-Number: 10150
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 17 Sep 2018 21:14:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180917/15be26ed/attachment.html>