[Asterisk-code-review] rtp engine: rtcp report to json can overflow the ssrc intege... (asterisk[15])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/10150 )

Change subject: rtp_engine: rtcp_report_to_json can overflow the ssrc integer value
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/10150/4/include/asterisk/json.h
File include/asterisk/json.h:

https://gerrit.asterisk.org/#/c/10150/4/include/asterisk/json.h@116
PS4, Line 116: #if (HAVE_LLONG_MAX == 1 && HAVE_STRTOLL == 1)
> Should be […]
According to the C99 standard if those values are not defined they will be replaced with 0.

Having it as you have mentioned also misses the case where one of those values is defined, but set to 0. Meaning what you have will only work if both those values are defined (doesn't matter what the value is).



-- 
To view, visit https://gerrit.asterisk.org/10150
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I2af275286ee5e795b79f0c3d450d9e4b28e958b0
Gerrit-Change-Number: 10150
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 17 Sep 2018 20:33:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180917/6c7ea721/attachment.html>