[Asterisk-code-review] res pjproject: Add utility functions to convert between sock... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10013 )

Change subject: res_pjproject: Add utility functions to convert between socket structures
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/10013/5/include/asterisk/res_pjproject.h
File include/asterisk/res_pjproject.h:

https://gerrit.asterisk.org/#/c/10013/5/include/asterisk/res_pjproject.h@24
PS5, Line 24: #include "asterisk/netsock2.h"
Just forward declare struct ast_sockaddr rather than including netsock2.h which adds needless compilation dependencies.

struct ast_sockaddr;


https://gerrit.asterisk.org/#/c/10013/5/res/res_pjproject.c
File res/res_pjproject.c:

https://gerrit.asterisk.org/#/c/10013/5/res/res_pjproject.c@115
PS5, Line 115: #include "asterisk/test.h"
Add explicit include of netsock2.h so res_pjproject.h will not need to include it.


https://gerrit.asterisk.org/#/c/10013/5/res/res_pjproject.exports.in
File res/res_pjproject.exports.in:

https://gerrit.asterisk.org/#/c/10013/5/res/res_pjproject.exports.in@3
PS5, Line 3: 		LINKER_SYMBOL_PREFIXast_pjproject_*;
           : 		LINKER_SYMBOL_PREFIXast_sockaddr_from_pj_sockaddr;
           : 		LINKER_SYMBOL_PREFIXast_sockaddr_to_pj_sockaddr;
If anything, this should be changed to:

LINKER_SYMBOL_PREFIXast_*;

This way the file is unlikely to ever need changing again.



-- 
To view, visit https://gerrit.asterisk.org/10013
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: If0fc4bba9643f755604c6ffbb0d7cc46020bc761
Gerrit-Change-Number: 10013
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 06 Sep 2018 16:09:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180906/71d39777/attachment.html>