<p>Patch set 5:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10013">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10013/5/include/asterisk/res_pjproject.h">File include/asterisk/res_pjproject.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10013/5/include/asterisk/res_pjproject.h@24">Patch Set #5, Line 24:</a> <code style="font-family:monospace,monospace">#include "asterisk/netsock2.h"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Just forward declare struct ast_sockaddr rather than including netsock2.h which adds needless compilation dependencies.</p><p style="white-space: pre-wrap; word-wrap: break-word;">struct ast_sockaddr;</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10013/5/res/res_pjproject.c">File res/res_pjproject.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10013/5/res/res_pjproject.c@115">Patch Set #5, Line 115:</a> <code style="font-family:monospace,monospace">#include "asterisk/test.h"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add explicit include of netsock2.h so res_pjproject.h will not need to include it.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10013/5/res/res_pjproject.exports.in">File res/res_pjproject.exports.in:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10013/5/res/res_pjproject.exports.in@3">Patch Set #5, Line 3:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">             LINKER_SYMBOL_PREFIXast_pjproject_*;<br>          LINKER_SYMBOL_PREFIXast_sockaddr_from_pj_sockaddr;<br>            LINKER_SYMBOL_PREFIXast_sockaddr_to_pj_sockaddr;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">If anything, this should be changed to:</p><p style="white-space: pre-wrap; word-wrap: break-word;">LINKER_SYMBOL_PREFIXast_*;</p><p style="white-space: pre-wrap; word-wrap: break-word;">This way the file is unlikely to ever need changing again.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10013">change 10013</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10013"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: If0fc4bba9643f755604c6ffbb0d7cc46020bc761 </div>
<div style="display:none"> Gerrit-Change-Number: 10013 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jaco Kroon <jaco@uls.co.za> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Michael L. Young <elgueromexicano@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 06 Sep 2018 16:09:52 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>