[Asterisk-code-review] stasis cache: Prune stasis subscription change messages (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10023 )

Change subject: stasis_cache: Prune stasis_subscription_change messages
......................................................................


Patch Set 3: Code-Review-1

(5 comments)

https://gerrit.asterisk.org/#/c/10023/3//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10023/3//COMMIT_MSG@13
PS3, Line 13: the cache when a the corresponding unsubscribe is received.
s/a the/the/


https://gerrit.asterisk.org/#/c/10023/3/main/stasis_cache.c
File main/stasis_cache.c:

https://gerrit.asterisk.org/#/c/10023/3/main/stasis_cache.c@872
PS3, Line 872: 			ast_log(LOG_ERROR,
Why is this promoted to an error?  This seems more a temporary debugging change to me.


https://gerrit.asterisk.org/#/c/10023/3/main/stasis_cache.c@905
PS3, Line 905: 	prnt(where, "Type: %s  ID: %s  Hash: %u", stasis_message_type_name(entry->key.type), entry->key.id,
wrap long line


https://gerrit.asterisk.org/#/c/10023/3/main/stasis_cache.c@932
PS3, Line 932: 		return NULL;
new_name is leaked here.


https://gerrit.asterisk.org/#/c/10023/3/main/stasis_cache.c@939
PS3, Line 939: 			ast_log(LOG_ERROR, "Stasis cache container '%p' for '%s' did not register\n", cache->entries, new_name);
Wrap long line.



-- 
To view, visit https://gerrit.asterisk.org/10023
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d18905e477f3721815da91f30da8d3fbb2d4f56
Gerrit-Change-Number: 10023
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 05 Sep 2018 16:44:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180905/77f173e4/attachment-0001.html>