<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10023">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10023/3//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10023/3//COMMIT_MSG@13">Patch Set #3, Line 13:</a> <code style="font-family:monospace,monospace">the cache when a the corresponding unsubscribe is received.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/a the/the/</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10023/3/main/stasis_cache.c">File main/stasis_cache.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10023/3/main/stasis_cache.c@872">Patch Set #3, Line 872:</a> <code style="font-family:monospace,monospace">                        ast_log(LOG_ERROR,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why is this promoted to an error?  This seems more a temporary debugging change to me.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10023/3/main/stasis_cache.c@905">Patch Set #3, Line 905:</a> <code style="font-family:monospace,monospace">      prnt(where, "Type: %s  ID: %s  Hash: %u", stasis_message_type_name(entry->key.type), entry->key.id,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">wrap long line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10023/3/main/stasis_cache.c@932">Patch Set #3, Line 932:</a> <code style="font-family:monospace,monospace">             return NULL;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">new_name is leaked here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10023/3/main/stasis_cache.c@939">Patch Set #3, Line 939:</a> <code style="font-family:monospace,monospace">                  ast_log(LOG_ERROR, "Stasis cache container '%p' for '%s' did not register\n", cache->entries, new_name);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Wrap long line.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10023">change 10023</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10023"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I3d18905e477f3721815da91f30da8d3fbb2d4f56 </div>
<div style="display:none"> Gerrit-Change-Number: 10023 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 05 Sep 2018 16:44:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>