[Asterisk-code-review] stasis: Use an implementation specific channel snapshot cache. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/10478 )

Change subject: stasis: Use an implementation specific channel snapshot cache.
......................................................................


Patch Set 6:

(1 comment)

One minor optional finding. I'm curious though what kind of performance increase did you see with these changes?

https://gerrit.asterisk.org/#/c/10478/6/main/channel_internal_api.c
File main/channel_internal_api.c:

https://gerrit.asterisk.org/#/c/10478/6/main/channel_internal_api.c@1592
PS6, Line 1592: 	chan->snapshot = snapshot;
Bump the ref on the snapshot here instead of putting onus on caller.



-- 
To view, visit https://gerrit.asterisk.org/10478
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9334febff60a82d7c39703e49059fa3a68825786
Gerrit-Change-Number: 10478
Gerrit-PatchSet: 6
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 29 Oct 2018 19:14:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181029/ed4d1b6d/attachment.html>