<p style="white-space: pre-wrap; word-wrap: break-word;">One minor optional finding. I'm curious though what kind of performance increase did you see with these changes?</p><p><a href="https://gerrit.asterisk.org/10478">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10478/6/main/channel_internal_api.c">File main/channel_internal_api.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10478/6/main/channel_internal_api.c@1592">Patch Set #6, Line 1592:</a> <code style="font-family:monospace,monospace">      chan->snapshot = snapshot;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Bump the ref on the snapshot here instead of putting onus on caller.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10478">change 10478</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10478"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9334febff60a82d7c39703e49059fa3a68825786 </div>
<div style="display:none"> Gerrit-Change-Number: 10478 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 29 Oct 2018 19:14:50 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>