[Asterisk-code-review] testsuite: Added tests for correct packetization (testsuite[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10557 )

Change subject: testsuite: Added tests for correct packetization
......................................................................


Patch Set 1: Code-Review-1

(7 comments)

All of your scripts have trailing white-space (shown as red blobs on gerrit UI).

https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/ast1/extensions.conf
File tests/channels/pjsip/rtp_ptime/non-transcode/ast1/extensions.conf:

PS1: 
Should this file be deleted (configs/ast1/extensions.conf used instead)?


https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/ast1/pjsip.conf
File tests/channels/pjsip/rtp_ptime/non-transcode/ast1/pjsip.conf:

PS1: 
Should this file be deleted?


https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/configs/ast1/pjsip.conf
File tests/channels/pjsip/rtp_ptime/non-transcode/configs/ast1/pjsip.conf:

PS1: 
Could you run this test with REF_DEBUG enabled?  As is it will likely leak.  If so this can normally be fixed by adding the following section to pjsip.conf:
[system]
type=system
timer_t1=100
timer_b=6400

Doing so also requires setting test_config={'memcheck-delay-stop': 7} in run-tests call to SIPpTest (delay longer than timer_b).


https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/run-test
File tests/channels/pjsip/rtp_ptime/non-transcode/run-test:

https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/run-test@50
PS1, Line 50:     test = SIPpTest(WORKING_DIR, TEST_DIR, SIPP_SCENARIOS)
test = SIPpTest(WORKING_DIR, TEST_DIR, SIPP_SCENARIOS, test_config={'memcheck-delay-stop':7})


https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/test-config.yaml
File tests/channels/pjsip/rtp_ptime/non-transcode/test-config.yaml:

https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/test-config.yaml@9
PS1, Line 9:         - app : 'rtpdump'
As is the test should also list:
- app : 'perl'

Worth noting nothing else in the testsuite depends on perl.  I'm guessing it would be preferred for those two scripts to be in python but I'm not sure if that's a big issue.


https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/transcode/configs/ast1/pjsip.conf
File tests/channels/pjsip/rtp_ptime/transcode/configs/ast1/pjsip.conf:

PS1: 
Same comment about adding [system] section.


https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/transcode/run-test
File tests/channels/pjsip/rtp_ptime/transcode/run-test:

https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/transcode/run-test@50
PS1, Line 50:     test = SIPpTest(WORKING_DIR, TEST_DIR, SIPP_SCENARIOS)
test_config argument here as well.



-- 
To view, visit https://gerrit.asterisk.org/10557
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I16cfb5805d2b96fdf5cdbc8f53a86522d1d251a7
Gerrit-Change-Number: 10557
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Cripps <rcripps at voxbone.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Comment-Date: Mon, 29 Oct 2018 11:46:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181029/a849e2bd/attachment-0001.html>