<p style="white-space: pre-wrap; word-wrap: break-word;">All of your scripts have trailing white-space (shown as red blobs on gerrit UI).</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10557">View Change</a></p><p>7 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/ast1/extensions.conf">File tests/channels/pjsip/rtp_ptime/non-transcode/ast1/extensions.conf:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/ast1/extensions.conf">Patch Set #1:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">Should this file be deleted (configs/ast1/extensions.conf used instead)?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/ast1/pjsip.conf">File tests/channels/pjsip/rtp_ptime/non-transcode/ast1/pjsip.conf:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/ast1/pjsip.conf">Patch Set #1:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">Should this file be deleted?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/configs/ast1/pjsip.conf">File tests/channels/pjsip/rtp_ptime/non-transcode/configs/ast1/pjsip.conf:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/configs/ast1/pjsip.conf">Patch Set #1:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">Could you run this test with REF_DEBUG enabled?  As is it will likely leak.  If so this can normally be fixed by adding the following section to pjsip.conf:<br>[system]<br>type=system<br>timer_t1=100<br>timer_b=6400</p><p style="white-space: pre-wrap; word-wrap: break-word;">Doing so also requires setting test_config={'memcheck-delay-stop': 7} in run-tests call to SIPpTest (delay longer than timer_b).</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/run-test">File tests/channels/pjsip/rtp_ptime/non-transcode/run-test:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/run-test@50">Patch Set #1, Line 50:</a> <code style="font-family:monospace,monospace">    test = SIPpTest(WORKING_DIR, TEST_DIR, SIPP_SCENARIOS)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">test = SIPpTest(WORKING_DIR, TEST_DIR, SIPP_SCENARIOS, test_config={'memcheck-delay-stop':7})</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/test-config.yaml">File tests/channels/pjsip/rtp_ptime/non-transcode/test-config.yaml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/non-transcode/test-config.yaml@9">Patch Set #1, Line 9:</a> <code style="font-family:monospace,monospace">        - app : 'rtpdump'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">As is the test should also list:</p><ul><li>app : 'perl'</li></ul><p style="white-space: pre-wrap; word-wrap: break-word;">Worth noting nothing else in the testsuite depends on perl.  I'm guessing it would be preferred for those two scripts to be in python but I'm not sure if that's a big issue.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/transcode/configs/ast1/pjsip.conf">File tests/channels/pjsip/rtp_ptime/transcode/configs/ast1/pjsip.conf:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/transcode/configs/ast1/pjsip.conf">Patch Set #1:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">Same comment about adding [system] section.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/transcode/run-test">File tests/channels/pjsip/rtp_ptime/transcode/run-test:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/transcode/run-test@50">Patch Set #1, Line 50:</a> <code style="font-family:monospace,monospace">    test = SIPpTest(WORKING_DIR, TEST_DIR, SIPP_SCENARIOS)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">test_config argument here as well.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10557">change 10557</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10557"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I16cfb5805d2b96fdf5cdbc8f53a86522d1d251a7 </div>
<div style="display:none"> Gerrit-Change-Number: 10557 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Robert Cripps <rcripps@voxbone.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 29 Oct 2018 11:46:52 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>