[Asterisk-code-review] testsuite: add test to verify reinvites with rewrite contact (testsuite[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/10532 )

Change subject: testsuite: add test to verify reinvites with rewrite_contact
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/10532/1/tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/sipp/uac-route-set.xml
File tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/sipp/uac-route-set.xml:

https://gerrit.asterisk.org/#/c/10532/1/tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/sipp/uac-route-set.xml@67
PS1, Line 67:   <pause ="10000" />
This is missing the attribute name, milliseconds="10000"


https://gerrit.asterisk.org/#/c/10532/1/tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/test-config.yaml
File tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/test-config.yaml:

https://gerrit.asterisk.org/#/c/10532/1/tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/test-config.yaml@11
PS1, Line 11:         updated. We then hang up the call, and we ensure that the request URI 
Remove extra space at the end of the line.


https://gerrit.asterisk.org/#/c/10532/1/tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/test-config.yaml@26
PS1, Line 26:     ami-action:
            :         delay: 2
            :         args:
            :             Action: 'Hangup'
            :             Channel: '/PJSIP/sipp-.*/'
I feel like this could potentially cause a race condition on some slower systems where the call gets hung up too early thus failing the test.

I'd suggest using the EventAction module if possible, which can listen for a specified AMI event and then trigger the action. However, not sure off the top of my head what event you could listen for, so if there is not one that makes sense then this might be only way.


https://gerrit.asterisk.org/#/c/10532/1/tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/test-config.yaml@36
PS1, Line 36:         - asterisk: 'res_pjsip'
add app_echo as a dependency as well.



-- 
To view, visit https://gerrit.asterisk.org/10532
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6a2cbb21acac4837131f5d048b148658160367e
Gerrit-Change-Number: 10532
Gerrit-PatchSet: 1
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 25 Oct 2018 19:01:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181025/8f4dc245/attachment.html>