<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10532">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10532/1/tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/sipp/uac-route-set.xml">File tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/sipp/uac-route-set.xml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10532/1/tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/sipp/uac-route-set.xml@67">Patch Set #1, Line 67:</a> <code style="font-family:monospace,monospace"> <pause ="10000" /></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is missing the attribute name, milliseconds="10000"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10532/1/tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/test-config.yaml">File tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/test-config.yaml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10532/1/tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/test-config.yaml@11">Patch Set #1, Line 11:</a> <code style="font-family:monospace,monospace"> updated. We then hang up the call, and we ensure that the request URI </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove extra space at the end of the line.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10532/1/tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/test-config.yaml@26">Patch Set #1, Line 26:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ami-action:<br> delay: 2<br> args:<br> Action: 'Hangup'<br> Channel: '/PJSIP/sipp-.*/'<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I feel like this could potentially cause a race condition on some slower systems where the call gets hung up too early thus failing the test.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd suggest using the EventAction module if possible, which can listen for a specified AMI event and then trigger the action. However, not sure off the top of my head what event you could listen for, so if there is not one that makes sense then this might be only way.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10532/1/tests/channels/pjsip/nat/rewrite_contact/route_set_reinvite/test-config.yaml@36">Patch Set #1, Line 36:</a> <code style="font-family:monospace,monospace"> - asterisk: 'res_pjsip'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">add app_echo as a dependency as well.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10532">change 10532</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10532"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib6a2cbb21acac4837131f5d048b148658160367e </div>
<div style="display:none"> Gerrit-Change-Number: 10532 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 25 Oct 2018 19:01:07 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>