[Asterisk-code-review] bridge softmix: Add SDP "label" attribute to streams (asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10484 )

Change subject: bridge_softmix:  Add SDP "label" attribute to streams
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Looks ok.  Just some trivial nits.

https://gerrit.asterisk.org/#/c/10484/1/bridges/bridge_softmix.c
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/#/c/10484/1/bridges/bridge_softmix.c@a2343
PS1, Line 2343: 
stray blank line deletion


https://gerrit.asterisk.org/#/c/10484/1/bridges/bridge_softmix.c@501
PS1, Line 501: 	const char *channel_name, const char *channel_uniqueid,
A channel's uniqueid may be what you put there but it doesn't have to be right?  How about naming the parameter sdp_label?


https://gerrit.asterisk.org/#/c/10484/1/include/asterisk/bridge.h
File include/asterisk/bridge.h:

https://gerrit.asterisk.org/#/c/10484/1/include/asterisk/bridge.h@294
PS1, Line 294: 	 * Add a "label" attribute to each stream in the the SDP containing
s/the the/the/



-- 
To view, visit https://gerrit.asterisk.org/10484
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieddeca5799d710cad083af3fcc3e677fa2a2a499
Gerrit-Change-Number: 10484
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 19 Oct 2018 19:33:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181019/d2a6e8b6/attachment-0001.html>