<p style="white-space: pre-wrap; word-wrap: break-word;">Looks ok.  Just some trivial nits.</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10484">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10484/1/bridges/bridge_softmix.c">File bridges/bridge_softmix.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10484/1/bridges/bridge_softmix.c@a2343">Patch Set #1, Line 2343:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">stray blank line deletion</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10484/1/bridges/bridge_softmix.c@501">Patch Set #1, Line 501:</a> <code style="font-family:monospace,monospace">     const char *channel_name, const char *channel_uniqueid,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">A channel's uniqueid may be what you put there but it doesn't have to be right?  How about naming the parameter sdp_label?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10484/1/include/asterisk/bridge.h">File include/asterisk/bridge.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10484/1/include/asterisk/bridge.h@294">Patch Set #1, Line 294:</a> <code style="font-family:monospace,monospace">     * Add a "label" attribute to each stream in the the SDP containing</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/the the/the/</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10484">change 10484</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10484"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ieddeca5799d710cad083af3fcc3e677fa2a2a499 </div>
<div style="display:none"> Gerrit-Change-Number: 10484 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 19 Oct 2018 19:33:42 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>