[Asterisk-code-review] res/res pjsip sip message: added sip message event notifier (asterisk[master])

sungtae kim asteriskteam at digium.com
Wed Nov 28 13:48:31 CST 2018


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/10715 )

Change subject: res/res_pjsip_sip_message: added sip message event notifier
......................................................................


Patch Set 3:

Wow... Thank you so much for all of opinions... I couldn't think about getting these so many comments. :D

- Disable the this module as default -> Add it disable to the samples.
- Change the module name -> I've checked all the res_stasis_* modules. But those modules are some ARI interface modules... not like this module. Is it OK to change the name?


-- 
To view, visit https://gerrit.asterisk.org/10715
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dedcc678265ebb74d35e7a2f58bc4b5084bcfe1
Gerrit-Change-Number: 10715
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Wed, 28 Nov 2018 19:48:31 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181128/4a569357/attachment.html>


More information about the asterisk-code-review mailing list