[Asterisk-code-review] res/res pjsip sip message: added sip message event notifier (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10715 )

Change subject: res/res_pjsip_sip_message: added sip message event notifier
......................................................................


Patch Set 3:

> Although I technically agree with Josh and Michael in that it would
 > seem that ARI is probably not the "proper" interface to send out
 > SIP messages, I find sometimes that it's useful to let people try
 > things out to see if my assumptions about the world are incorrect. 
 > My personal opinion (not project lead opinion) is that I would be
 > ok with the module going in as long as it's disabled (doesn't build
 > or isn't active) by default and not core supported.  Anybody else
 > want to weigh in?

I have no complaint about making it an option as long as menuselect has it disabled by default.  Probably add the noload to modules.conf installed by 'make samples' with a comment about performance costs.

The CI scripts enable all 'res' modules that can be built so I think we should make sure the testsuite noload's the module to avoid the performance hit.  Letting CI build the module would be best so we can get compile only CI coverage.

I'm not sure about the current name of this module.  Maybe this is more of a res_stasis_* module?


-- 
To view, visit https://gerrit.asterisk.org/10715
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dedcc678265ebb74d35e7a2f58bc4b5084bcfe1
Gerrit-Change-Number: 10715
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Wed, 28 Nov 2018 17:33:11 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181128/9267aa77/attachment.html>