[Asterisk-code-review] res/res pjsip sip message: added sip message event notifier (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10715 )

Change subject: res/res_pjsip_sip_message: added sip message event notifier
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/10715/3//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10715/3//COMMIT_MSG@9
PS3, Line 9: This module is sending event messages for giving channel's SIP
           : messages. This module will be helpful for checking more detail SIP
           : messages. Because of the ISDN cause codes are not 1:1 compatible with
           : SIP response code, it was hard to know what was the real problem. Not
           : only for response code, this would be useful for examining the received
           : SIP messages easily.
> I agree with the performance issues.  […]
We provide a CLI command, "pjsip set logger on", which is used for SIP debugging purposes. ARI isn't an interface meant for that.

Asterisk stores not just the ISDN cause code, but also the SIP response codes. Those are not currently sent or exposed over ARI but could be.



-- 
To view, visit https://gerrit.asterisk.org/10715
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dedcc678265ebb74d35e7a2f58bc4b5084bcfe1
Gerrit-Change-Number: 10715
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Wed, 28 Nov 2018 13:49:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181128/9bb269bb/attachment.html>