[Asterisk-code-review] res/res pjsip sip message: added sip message event notifier (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/10715 )

Change subject: res/res_pjsip_sip_message: added sip message event notifier
......................................................................


Patch Set 3:

(3 comments)

Thank you for kind review. I've replied to your comments.

https://gerrit.asterisk.org/#/c/10715/3//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10715/3//COMMIT_MSG@9
PS3, Line 9: This module is sending event messages for giving channel's SIP
           : messages. This module will be helpful for checking more detail SIP
           : messages. Because of the ISDN cause codes are not 1:1 compatible with
           : SIP response code, it was hard to know what was the real problem. Not
           : only for response code, this would be useful for examining the received
           : SIP messages easily.
> Personally I don't like that this just sends the SIP messages to ARI. […]
I agree with the performance issues. 

Not only for the Reason item in the SIP messages, sometimes, user needed to digging the SIP message to find what's wrong in the SIP.

I think this module would be helpful for that cases.

Btw, your link is not clear.. The thing is, Asterisk's Hangup cause is mapped more than 2 SIP reason. And the SIP's response message could be have more than 2 reasons.


https://gerrit.asterisk.org/#/c/10715/3/res/res_pjsip_sip_message.c
File res/res_pjsip_sip_message.c:

https://gerrit.asterisk.org/#/c/10715/3/res/res_pjsip_sip_message.c@294
PS3, Line 294: if
I will fix this space soon.


https://gerrit.asterisk.org/#/c/10715/3/res/res_pjsip_sip_message.c@326
PS3, Line 326: if
I will fix this space soon.



-- 
To view, visit https://gerrit.asterisk.org/10715
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dedcc678265ebb74d35e7a2f58bc4b5084bcfe1
Gerrit-Change-Number: 10715
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Wed, 28 Nov 2018 13:46:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181128/a39bf2c8/attachment-0001.html>