[Asterisk-code-review] app queue: Revert broken queue channel reference patch (asterisk[16])

Joshua Colp asteriskteam at digium.com
Tue Nov 27 06:26:12 CST 2018


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10523 )

Change subject: app_queue: Revert broken queue channel reference patch
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/10523/6//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10523/6//COMMIT_MSG@12
PS6, Line 12: ASTERISK-25185, ASTERISK-27006, ASTERISK-25844, ASTERISK-28125
Please replace "-" with "~" in these issue ids, or else they will all automatically close and not remain open.


https://gerrit.asterisk.org/#/c/10523/6/apps/app_queue.c
File apps/app_queue.c:

https://gerrit.asterisk.org/#/c/10523/6/apps/app_queue.c@2189
PS6, Line 2189: 		ast_log(LOG_WARNING, "Empty caller_snapshot; sending incomplete event\n");
This message isn't really useful to an end-user. If there's any information we can get from here to provide a hint, that'd be good.



-- 
To view, visit https://gerrit.asterisk.org/10523
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I37334ea184ebb56e54471496b82937d4927815a0
Gerrit-Change-Number: 10523
Gerrit-PatchSet: 6
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: lvl <digium at lvlconsultancy.nl>
Gerrit-Comment-Date: Tue, 27 Nov 2018 12:26:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181127/58b715a8/attachment.html>


More information about the asterisk-code-review mailing list